The Daily Shaarli

All links of one day in a single page.

February 22, 2020

10 tips for reviewing code you don't like - Red Hat Developer

Quelques conseils pour faire des reviews constructives:

  1. Rephrase your objection as a question
  2. Avoid hyperbole
  3. Keep snide comments to yourself
  4. Engage positively
  5. Remember that not everybody’s experience is identical to yours
  6. Don’t diminish the complexity of something that’s not obvious
  7. Be respectful
  8. Manage expectations (and your time)
  9. Say please
  10. Start a conversation